Hendrik Ranocha

Results 378 comments of Hendrik Ranocha

So it was the change https://github.com/JuliaSIMD/LoopVectorization.jl/compare/v0.12.128...v0.12.129 This introduced the additional check `LoopVectorization.can_turbo` before the turbo version. This check fails for `foo` in the minimal example. Thus, the fallback `Base.Broadcast.materialize!(dest, bc)`...

@chriselrod What is the recommended way to get `LoopVectorization.can_turbo(f, ::Val{N}) = true` for something defined in a package? In this case, it is basically https://github.com/SciML/DiffEqBase.jl/blob/c5154b8be87531a345591db90d3a76b0e8c4d738/src/calculate_residuals.jl#L94-L99 and its related functions. Note...

> Does that mean that we will always run into a stack overflow whenever we do something like this without setting `can_turbo` to `true` first? That seems unintended. Yes

Thanks a lot for the hotfix, @chriselrod! I can confirm that it fixes the original issue reported in https://github.com/JuliaSIMD/StrideArrays.jl/pull/60#issuecomment-1334909937

Feel free to close this - or leave it open as a reference to the better fix described above

Yeah, I agree. I just wanted to start with something simple to see whether CI passes. Looks like there are two issues - Aqua.jl detects a type piracy in https://github.com/JuliaSIMD/StrideArrays.jl/blob/main/src/blas.jl#L6...

> Why `vcat` no longer returns static sizes will need investigating. Bisected to the update of StrideArraysCore.jl v0.4.6 -> v0.4.7 using the following code ```julia julia> using Pkg; Pkg.activate(temp =...

> That this type priates `StrideArraysCore` is expected. I disabled the piracy tests. Since this requires Aqua.jl v0.6, I added compat bounds to `test/Project.toml` and let CompatHelper track them.

> > Why `vcat` no longer returns static sizes will need investigating. > > Bisected to the update of StrideArraysCore.jl v0.4.6 -> v0.4.7 using the following code > > ```julia...

It looks like the change in https://github.com/JuliaSIMD/StrideArraysCore.jl/compare/v0.4.6...v0.4.7#diff-99b463e6d0d4aa026397c8d135183d2e509cf0c20acbf41fe835c05b69dbc269R263 causes the different behavior.