SummationByPartsOperators.jl icon indicating copy to clipboard operation
SummationByPartsOperators.jl copied to clipboard

Create FormatCheck.yml

Open ranocha opened this issue 1 year ago • 3 comments

ranocha avatar Aug 01 '24 08:08 ranocha

Codecov Report

Attention: Patch coverage is 86.86869% with 208 lines in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (69abce3) to head (31686d5). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...P_coefficients/DienerDorbandSchnetterTiglio2007.jl 11.86% 104 Missing :warning:
src/coupling.jl 89.43% 45 Missing :warning:
src/fourier_operators.jl 90.71% 17 Missing :warning:
src/SBP_operators.jl 90.54% 14 Missing :warning:
src/upwind_operators.jl 87.50% 7 Missing :warning:
src/fourier_operators_2d.jl 87.87% 4 Missing :warning:
...ficients/MattssonAlmquistVanDerWeide2018Minimal.jl 95.83% 3 Missing :warning:
src/filter.jl 70.00% 3 Missing :warning:
src/general_operators.jl 91.17% 3 Missing :warning:
src/dissipation_operators.jl 95.45% 2 Missing :warning:
... and 6 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          37       37           
  Lines        5717     5742   +25     
=======================================
+ Hits         5256     5279   +23     
- Misses        461      463    +2     
Flag Coverage Δ
unittests 91.93% <86.86%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 01 '24 08:08 codecov[bot]

Coverage Status

coverage: 92.644% (+0.007%) from 92.637% when pulling 31686d585b2f5fc606ddb82c0b0692632837989a on ranocha-patch-1 into 69abce395a7176a336a258f4408357e32da1899a on main.

coveralls avatar Aug 01 '24 08:08 coveralls

As a note: If the formatter fails for a file or multiple files that are not part of the diff, there can be no suggestions by reviewdog, i.e. in this case you need to run the formatter locally first.

JoshuaLampert avatar Aug 01 '24 15:08 JoshuaLampert

What's the status with this PR? I think it would be good to have the code formatted with JuliaFormatter.jl. I can help if needed.

JoshuaLampert avatar Mar 17 '25 18:03 JoshuaLampert

The issue is that this requires a lot of changes to be reviewed. It would be great if you would like to help me with that.

ranocha avatar Mar 18 '25 05:03 ranocha

Thanks a lot! I decided to remove the dev folder from the formatter.

ranocha avatar Mar 18 '25 12:03 ranocha

Thanks a lot! I decided to remove the dev folder from the formatter.

Yeah, that probably makes sense.

JoshuaLampert avatar Mar 18 '25 12:03 JoshuaLampert