node-argon2 icon indicating copy to clipboard operation
node-argon2 copied to clipboard

Cannot build anymore from yesterday: Cannot find module './**/*'

Open Kliton opened this issue 1 year ago • 7 comments

Hi, since yesterday all my projects that contains node2-argon cannot build.

Error that i got: #23 9.755 Error: Cannot find module './**/*' #23 9.755 Require stack: #23 9.755 - /app/node_modules/@mapbox/node-pre-gyp/lib/node-pre-gyp.js #23 9.755 - /app/node_modules/argon2/argon2.js

I've also tried upgrading argon to 0.31.0 but the problem is still there.

Kliton avatar Aug 28 '23 10:08 Kliton

I think I have the same problem. I am not sure if it is only happening on Macbooks with M1 CPU because it doesn't fail to install when we run npm install in a docker alpine image and the containers runs correctly.

node-pre-gyp install --fallback-to-build
node-pre-gyp ERR! install response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.28.2/argon2-v0.28.2-napi-v3-darwin-arm64-unknown.tar.gz 
node-pre-gyp WARN Pre-built binaries not installable for [email protected] and [email protected] (node-v83 ABI, unknown) (falling back to source compile with node-gyp) 
node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.28.2/argon2-v0.28.2-napi-v3-darwin-arm64-unknown.tar.gz 
  CC(target) Release/obj.target/libargon2/argon2/src/ref.o
  CC(target) Release/obj.target/libargon2/argon2/src/argon2.o
  CC(target) Release/obj.target/libargon2/argon2/src/core.o
  CC(target) Release/obj.target/libargon2/argon2/src/blake2/blake2b.o
  CC(target) Release/obj.target/libargon2/argon2/src/thread.o
  CC(target) Release/obj.target/libargon2/argon2/src/encoding.o
  LIBTOOL-STATIC Release/argon2.a
  CXX(target) Release/obj.target/argon2/src/argon2_node.o
  SOLINK_MODULE(target) Release/argon2.node
  COPY /Users/robertoalvarez/Documents/Paystand/DeFi-Card/be-virtualcard/node_modules/argon2/lib/binding/napi-v3/argon2.node
  TOUCH Release/obj.target/action_after_build.stamp```

ralvare avatar Aug 29 '23 22:08 ralvare

Same here. On npm install / npm install argon2 a fetch for the pre-built binaries seems to fail on a 404 Not Found:

npm ERR! node-pre-gyp http GET https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-darwin-arm64-unknown.tar.gz
npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-darwin-arm64-unknown.tar.gz 
npm ERR! node-pre-gyp WARN Pre-built binaries not installable for [email protected] and [email protected] (node-v108 ABI, unknown) (falling back to source compile with node-gyp) 
npm ERR! node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-darwin-arm64-unknown.tar.gz 

Running on Apple Silicon, macOS 13.4.1. The script seems to attempt to fetch https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-darwin-arm64-unknown.tar.gz but in the GitHub releases for v0.31.0 the file name is https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-darwin-x64-unknown.tar.gz. The script attempts "arm64" as an architecture but the prebuilt binary seems to expect "x64".

jonrh avatar Aug 31 '23 18:08 jonrh

On a closer look it seems that in commit https://github.com/ranisalt/node-argon2/commit/51d8364c56b33dc96fb1eec0941d3c423b5e547a macos-m1 was removed as an extra release target. Maybe on accident.

# .github/workflows/release.yml
-        include:
-           - node-version: 16
-             os: macos-m1

Pre-built binaries were being published for macOS arm64 (Apple silicon) from v0.29.0 up until v0.30.3 but has been missing since v0.31.0. Have been tinkering around on a private fork but can not get the release pipline to run without some other unrelated issue. I suspect it can be fixed by adding macos-m1 as an OS to line 39 in .github/workflows/release.yml:

- os: [ubuntu-20.04, macos-11, windows-2019]
+ os: [ubuntu-20.04, macos-11, macos-m1, windows-2019]

On another note I would like to apolagize that this comment and my previous one are likely not related to the issue of the original submitter. Please let me know if a seperate issue should be created.

jonrh avatar Sep 07 '23 18:09 jonrh

@jonrh that's right, it was not intentional. Feel free to open a PR!

ranisalt avatar Sep 07 '23 18:09 ranisalt

Should be fixed on the latest release 0.31.2

ranisalt avatar Nov 16 '23 13:11 ranisalt

Same problem :(

Eriickson avatar Nov 30 '23 23:11 Eriickson

Alpha versions released under the next tag will not have issues with missing binary downloads. You can try it by installing argon2@next with your preferred package manager, the rest of the library remains the same

ranisalt avatar Dec 30 '23 12:12 ranisalt

Should be fixed with v0.40.1

ranisalt avatar Feb 23 '24 22:02 ranisalt