node-argon2 icon indicating copy to clipboard operation
node-argon2 copied to clipboard

armv7 failing to find release

Open SelfhostedPro opened this issue 2 years ago • 7 comments

Steps to reproduce

  1. Try to build docker container with arm support using buildx
  2. It should fail when getting to the section where argon2 is downloaded with a 404 error.
  3. Action with logs available here: https://github.com/SelfhostedPro/yacht-api/actions/runs/4848340232/jobs/8639369035

Expected behaviour

For the package to be available and downloads without issue.

Actual behaviour

Fails with the following error:

#39 [linux/arm/v7 base  8/14] RUN pnpm -r fetch
#39 324.2 .../[email protected]/node_modules/argon2 install: node-pre-gyp ERR! install response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.30.3/argon2-v0.30.3-napi-v3-linux-arm-musl.tar.gz 
#39 324.2 .../[email protected]/node_modules/argon2 install: node-pre-gyp WARN Pre-built binaries not installable for [email protected] and [email protected] (node-v108 ABI, musl) (falling back to source compile with node-gyp) 
#39 324.2 .../[email protected]/node_modules/argon2 install: node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.30.3/argon2-v0.30.3-napi-v3-linux-arm-musl.tar.gz 
#39 325.0 .../node_modules/vue-demi postinstall: Done

Environment

Operating system: linux/armv7 Github Actions Runner BuildX

Node version: 18 alpine lts (pnpm)

SelfhostedPro avatar May 01 '23 04:05 SelfhostedPro

Im also seeing this behaviour... it appears the latest release did not build/publish all the targets of previous releases.

adamwdennis avatar Aug 22 '23 17:08 adamwdennis

The same happened for me with the linux arm64 architecture.

.../[email protected]/node_modules/argon2 install: node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-linux-arm64-glibc.tar.gz 

0x524c avatar Aug 23 '23 12:08 0x524c

@SelfhostedPro is your device running 32-bit ARM? I see that it tries to load for architecture arm rather than arm64

@adamwdennis indeed, I'll try to trigger the builds again. Github Actions is spectacularly inconsistent

@524c that is not an error, that is just a normal info message

ranisalt avatar Aug 23 '23 13:08 ranisalt

Hi @ranisalt,

Sorry, the previous parts I've highlighted from the logs aren't correct. The correct are this: .../[email protected]/node_modules/argon2 install: node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-linux-arm64-glibc.tar.gz

I downgraded from 0.31.0 to 0.30.3 and everything was fine.

0x524c avatar Aug 23 '23 13:08 0x524c

@524c I noticed issues with the publishing of ARM64 builds for version 0.31.0 due to a bump in the minimum Node version (14 to 16)

ranisalt avatar Aug 23 '23 21:08 ranisalt

@524c I noticed issues with the publishing of ARM64 builds for version 0.31.0 due to a bump in the minimum Node version (14 to 16)

If I can help with anything.. thank you for your support.

0x524c avatar Aug 23 '23 23:08 0x524c

Alpha versions released under the next tag will not have issues with missing binary downloads. You can try it by installing argon2@next with your preferred package manager, the rest of the library remains the same

ranisalt avatar Dec 30 '23 12:12 ranisalt

Should be fixed with v0.40.1

ranisalt avatar Feb 23 '24 22:02 ranisalt