Elina

Results 255 comments of Elina

Requesting my own review so I don't forget. This is something I've experimented with and can be very useful when it comes to lazy loading modules

> This implementation and threadsafe futures is basically a low-level requirement necessary to implement Rust's async functions correctly in wasm. Does that mean that the implementation in `task/singlethreaded.rs` is incorrect?...

There doesn't seem to be any activity on this for quite a while. What's blocking this from being merged? Is it not being worked on anymore?

It seems as a fix for the Firefox bug is underway. I would say we shouldn't merge this and let Firefox handle it.

Sorry, took me a while to get to this. It looks good! Thanks for the PR (and the wait)

There has been no activity because no there are no active maintainers. This PR is needed for tui editor to compile with typescript

Since we introduce unsafe here to build a data structure, we should also run Miri in the CI to ensure correctness of the unsafe code

> Under what kind of circumstances, would one of the public built-in hook want to return `&T` than `Rc` (or one of the handle type)? Assuming that `Handle` types can...

https://github.com/yewstack/yew/pull/2321 adds a section about component communication (see [here](https://yew-rs--pr2321-docs-overhaul-2w2sda7w.web.app/docs/next/concepts/components#passing-data-to-a-component)). It only mentions props for parent to child communication and suggests using contexts for everything else. As suggested in this issue,...

[cargo hack](https://github.com/taiki-e/cargo-hack) may be helpful here