redux-beacon icon indicating copy to clipboard operation
redux-beacon copied to clipboard

Add allowIDFA to react native GA

Open djw27 opened this issue 6 years ago • 4 comments

Checklist

  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [x] I have added all necessary documentation (if appropriate)

What was done

Added functionality to allow IDFA collection for the react-native Google Analytics package. This signals to GA whether the app is allowed to use the advertiser identifier for the device to deliver adds or collect ad click attribution.

Not sure how to go about adding a test for this, we've been using this change in production for a while now.

djw27 avatar Jun 06 '18 10:06 djw27

Nice work. I'm curious about something though...are there scenarios where we'd need to set allowIDFA multiple times throughout the lifecycle of the app? I'm thinking that perhaps this is more of a setting rather than an event:

function GoogleAnalytics(
  trackingId: string,
  GoogleAnalyticsTracker: any
  settings?: { allowIdfa?: boolean }
)

ttmarek avatar Jun 06 '18 21:06 ttmarek

I agree with you - the only counter point would be to keep consistency with react-native-google-analytics-bridge?

djw27 avatar Jun 07 '18 08:06 djw27

Hmm...I see...

Honestly, I'd prefer if we remain consistent with our own abstractions. Otherwise all our targets might diverge in methodology/usage. I'd like the experience from target to target to be as similar as possible.

ttmarek avatar Jun 08 '18 16:06 ttmarek

@ttmarek not a problem! I agree with you.

djw27 avatar Jun 11 '18 13:06 djw27