phantomstyle icon indicating copy to clipboard operation
phantomstyle copied to clipboard

NEW: option to hide checkmarks in menu when items has an icon (closer…

Open JulienMaille opened this issue 5 years ago • 6 comments

… to standard windows style)

image

JulienMaille avatar Dec 17 '19 20:12 JulienMaille

Oops some of my specular branch went in this PR, I will clean this up

JulienMaille avatar Dec 19 '19 07:12 JulienMaille

No rush :)

randrew avatar Dec 19 '19 09:12 randrew

OK, thanks for fixing the formatting issues.

I've taken a look at your changes. There are a few problems. Let's start with the first.

The checkmark appearance in menu items has been affected by your change. They are no longer correctly sized or aligned.

Here is how the "Charlie" menu appears in the "funhouse" example project before your changes:

funhouse_NlBvEWPCBg

But here it is after your changes:

funhouse_B5hNEDiZbA

randrew avatar Dec 27 '19 01:12 randrew

I think it's much better now, can you detail the other issues you found?

JulienMaille avatar Dec 29 '19 20:12 JulienMaille

Sorry, I'm busy right now. It will take me a few days to get to this.

randrew avatar Dec 30 '19 03:12 randrew

No problem, let me know if I can help.

JulienMaille avatar Jan 08 '20 21:01 JulienMaille