randombit
[TODO] X509_DN Normalize function update to utilize structed bindings
Hello,
While reviewing the project's codebase, I encountered the following TODO comment:
// TODO: C++14 - use std::get<ASN1_String>(), resp. std::get<OID>()
This indicated an opportunity to modernize the code using structured bindings. I refactored the normalize function to enhance readability and maintainability.
However, I currently lack access to a macOS environment to perform comprehensive testing. I will check it after the request to merge the automated tests is opened. I wanted you to know.
I hope this contribution proves beneficial to the project. Please feel free to suggest any modifications or improvements. I would like to help as soon as I am available.
Best regards
coverage: 90.557% (-0.004%) from 90.561% when pulling 07c8bbcc2a6568383793f297c690a79f6a8c47cb on KaganCanSit:todo-use-struct-bindings into c6c7423f6ca31b020c1be3e7ae3f5da6293a84bf on randombit:master.
@reneme I know you're usually less active here on the weekends and I wanted to talk about it because you've reviewed other PR content. If you're available right now, I think this PR is pretty small and can be implemented very quickly. It could help reduce the crowd of merge requests. I'd love it if you could take a look.
@reneme Thank you for your time. I personally set a goal of 12 open source contributions this year (7 of them to this project.) I finished early. It was a small but very motivating event. I will continue to contribute as much as I can.
Thank you for your support and knowledge sharing.