Cleanup in socket/asio code

Open randombit opened this issue 1 year ago • 2 comments

          Nit: This could now be calld `dns_result`, `endpoints` or something similar, as it is not technically an iterator anymore.

Originally posted by @reneme in https://github.com/randombit/botan/pull/4484#discussion_r1891349576

Also could use quite a bit of auto love to hide the various contorted type names.

Dec 19 '24 12:12 randombit

On that note we should probably update this guidance on using auto somewhat:

https://github.com/randombit/botan/blob/cc835ca8c4d82a515e83a17256177dafe980464a/doc/dev_ref/contributing.rst?plain=1#L218-L220

... probably better to extend to something like "... truly obvious or not particularly relevant to reason about the semantics".

Dec 19 '24 12:12 reneme

truly obvious or not particularly relevant to reason about the semantics

:+1:

Dec 19 '24 13:12 randombit