botan icon indicating copy to clipboard operation
botan copied to clipboard

Disabled code in EC_Group::point() intended?

Open lieser opened this issue 4 years ago • 1 comments

I noticed that EC_Group::point() contains some code that is disabled via #if 0. https://github.com/randombit/botan/blob/2fb7ba81b0304f0864a557e3f3a010f4c2ce08d3/src/lib/pubkey/ec_group/ec_group.cpp#L620-L628

Is this intended, or some leftover from development?

lieser avatar May 05 '22 10:05 lieser

That looks like debugging code, but we probably should be checking that x,y are a valid point.

randombit avatar May 18 '22 09:05 randombit