botan icon indicating copy to clipboard operation
botan copied to clipboard

Disable ECKCDSA signing when hash != order bits

Open randombit opened this issue 3 years ago • 1 comments

There are problems - GH #2742

randombit avatar May 20 '21 22:05 randombit

Codecov Report

Base: 91.79% // Head: 91.84% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (1e214e8) compared to base (d1f8181). Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2749      +/-   ##
==========================================
+ Coverage   91.79%   91.84%   +0.04%     
==========================================
  Files         602      602              
  Lines       72512    72514       +2     
  Branches     6622     6619       -3     
==========================================
+ Hits        66564    66598      +34     
+ Misses       5948     5916      -32     
Impacted Files Coverage Δ
src/lib/pubkey/eckcdsa/eckcdsa.cpp 95.95% <75.00%> (-0.95%) :arrow_down:
src/cli/entropy.cpp 82.60% <0.00%> (-4.35%) :arrow_down:
src/lib/misc/cryptobox/cryptobox.cpp 93.33% <0.00%> (-1.34%) :arrow_down:
src/lib/tls/tls12/tls_channel_impl_12.cpp 89.72% <0.00%> (-0.28%) :arrow_down:
src/cli/cli_rng.cpp 82.45% <0.00%> (+5.26%) :arrow_up:
src/lib/pbkdf/argon2/argon2pwhash.cpp 85.13% <0.00%> (+6.75%) :arrow_up:
src/lib/utils/cpuid/cpuid_x86.cpp 88.31% <0.00%> (+14.28%) :arrow_up:
src/lib/entropy/rdseed/rdseed.cpp 100.00% <0.00%> (+78.26%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar May 21 '21 00:05 codecov-commenter