Aristo
Aristo
@aakash232
Discussed with @priyansh4320 offline and he is onboard. We could use this case to investigate the limitation of conversable agent and clients on how we could support model specific features...
Few more comments, @priyansh4320 1. Why do we need test/test_backward_compatibility_sync.py and test/test_backward_compatibility_sync.py? We need to test the list[message] cases, and backward compatibility should be covered from previous tests. We only...
@priyansh4320 Search for "message = messages[-1]". All those lines may need to be updated to include the delta messages instead of the last one. i.e. if we send a list...
> Please add integration tests (not only unit test) for two agent chat, Nested Chat , group chat, group chat with Orchestration Patterns. Cover ConversableAgent::run, initiate_chat, initiate_chats, initiate_group_chat, run_group_chat and...
@priyansh4320 Could you separate the tests into separate files? Any code over 500 lines is bloated and we should avoid make it worse. Also separate unit tests and integration tests...
@randombet review this later.
@BlocUnited @priyansh4320 Could you break down this to multiple sub-issues?
@BlocUnited @priyansh4320 Follow up on this issue. We need to define clear objectives and milestones. Current Outcome session is too vague and big. For example, we would say, Phase 1....
@priyansh4320 Could you verify if my claim is valid? If yes, could you list the items we need to work on to make it work?