hauler icon indicating copy to clipboard operation
hauler copied to clipboard

split hauler login into registry and helm-repo

Open amartin120 opened this issue 3 months ago • 2 comments

Please check below, if the PR fulfills these requirements:

  • [x] Commit(s) and code follow the repositories guidelines.
  • [ ] Test(s) have been added or updated to support these change(s).
  • [ ] Doc(s) have been added or updated to support these change(s).

Associated Links:

  • In support of issue: https://github.com/rancherfederal/hauler/issues/190

Types of Changes:

  • feature and breaking change

Proposed Changes:

  • Hauler login was just for registries but we needed to add support for authenticated helm repos so this PR splits the hauler login command into hauler login registry and hauler login helm-repo.

Verification/Testing of Changes:

  • crossed two fingers and said some nice words.
  • repo info added to helm repositories file that's used by the helm client libraries.

Additional Context:

  • If you have an existing scripts using hauler login they will need to be adjusted accordingly.
❯ hauler login registry --help                                                                                                                                                                                                                                                                          
Log into an authenticated registry

Usage:
  hauler login registry [flags]

Aliases:
  registry, r

Examples:
hauler login registry reg.example.com -u bob -p haulin

Flags:
  -h, --help              help for registry
  -p, --password string   Password
      --password-stdin    Take the password from stdin
  -u, --username string   Username

Global Flags:
  -l, --log-level string    (default "info")
❯ hauler login helm-repo --help                                                                                                                                                                                                                                                                          
Authentication info for a helm repo

Usage:
  hauler login helm-repo [name] [url] [flags]

Aliases:
  helm-repo, h

Examples:
hauler login helm-repo my-helm-repo https://chart.repo.com -u bob -p haulin

Flags:
      --ca-file string             verify certificates of HTTPS-enabled servers using this CA bundle
      --cert-file string           identify HTTPS client using this SSL certificate file
  -h, --help                       help for helm-repo
      --insecure-skip-tls-verify   skip tls certificate checks for the chart download
      --key-file string            identify HTTPS client using this SSL key file
      --pass-credentials           pass credentials to all domains
  -p, --password string            chart repository password where to locate the requested chart
      --password-stdin             Take the password from stdin
  -u, --username string            chart repository username where to locate the requested chart

Global Flags:
  -l, --log-level string    (default "info")

amartin120 avatar Mar 12 '24 14:03 amartin120