ui icon indicating copy to clipboard operation
ui copied to clipboard

Include ember-api-store addon in the code base

Open nwmac opened this issue 1 year ago • 2 comments

This PR takes the code from https://github.com/rancher/ember-api-store and embeds it in the ui codebase.

ember-api-store is currently published as an npm module which complicates Ember migration since we need to migrate both projects. By inlining the code, we only have to migrate the ui codebase.

Note, there is a test directory, but as far as I can tell, this is all test framework and there are no tests, so this folder was removed.

I checked the dependencies and updated the package.json file to be consistent with the other addons. I added two dependencies to the top-level package file that look like they were needed (both cookie related).

The lint rules for this project were different to the ones in the ui repository, so fixed them automatically via eslint with the --fix option.

Tested manually by navigating around the UI, deploying a workload and scaling it up/down to check that the store operates as before.

nwmac avatar Nov 05 '24 16:11 nwmac

Is this still needed?

mantis-toboggan-md avatar May 30 '25 18:05 mantis-toboggan-md

@mantis-toboggan-md not sure it is. This was to help us more easily migrate to newer versions of Ember - but I think we can only go as far as 3.28 - so don’t know if it I worth it.

nwmac avatar May 30 '25 21:05 nwmac

Won't fix ahead of removal of the legacy UI

nwmac avatar Aug 19 '25 08:08 nwmac