system-upgrade-controller icon indicating copy to clipboard operation
system-upgrade-controller copied to clipboard

Published 20 hours ago • verified publisher icon rancher

fix imagePullPolicy

Open simonfelding opened this issue 10 months ago • 1 comments

If imagePullPolicy is set to IfNotPresent and the tag is :latest, you get very unintuitive behavior where Kubernetes will not actually get new versions. This kind of behavior is exactly why it's bad practice to use that tag.

Source: https://kubernetes.io/docs/concepts/containers/images/#updating-images

simonfelding avatar Apr 03 '24 08:04 simonfelding

It would probably be better to drop the explicit definition of the image pull policy and let the Kubernetes mutation webhook do its magic for the image tags.

SISheogorath avatar May 01 '24 02:05 SISheogorath

This is actually updated to point at the release tag as part of publish CI. If you consume the manifest from the release artifacts, instead of just applying what's in git, you should get the correct behavior.

brandond@dev01:~$ curl -sL https://github.com/rancher/system-upgrade-controller/releases/download/v0.13.4/system-upgrade-controller.yaml | grep image:
        image: rancher/system-upgrade-controller:v0.13.4

brandond avatar Aug 29 '24 17:08 brandond