fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Revisit directory-to-bundle logic

Open weyfonk opened this issue 1 year ago • 1 comments

While looking at this code and that one in the context of reading directories for determining which ones to create bundles from, it seems that we could probably simplify some of this logic:

  • [ ] this seems to browse each subdirectory multiple times, once from the filepath.Walk loop and once from shouldCreateBundleFromThisPath logic. Can we do better?
  • [ ] consider using WalkDir, supposedly more efficient than Walk.

Related to this comment.

weyfonk avatar Nov 26 '24 15:11 weyfonk

Let's wait how much of this is necessary after https://github.com/rancher/fleet/issues/210

manno avatar Jan 23 '25 12:01 manno

Already done.

weyfonk avatar Jul 16 '25 13:07 weyfonk