old release not removed during bundle update

[aDisplayName]

Is there an existing issue for this?

• [X] I have searched the existing issues

Current Behavior

When a bundle update in the Git Repository results in a new helm release name, the helm release installed by the previous version of the bundle definition is not being removed. It is then causing problem due to resource conflict if both release share the same namespace.

Expected Behavior

When a bundle update results in a change of helm release name, the bundle deployment should make sure the old helm release is removed by fleet agent, and the new helm release is created according to the bundle definition

Steps To Reproduce

1. Create a new GitRepo in Rancher Continuous Delivery with the following:

   apiVersion: fleet.cattle.io/v1alpha1
   kind: GitRepo
   metadata:
     name: github-issue-20240220
   spec:
     correctDrift:
       enabled: true
     paths:
       - /20240220
     repo: https://github.com/aDisplayName/bugsamplecode.git
     revision: 681b822618a0e89b4c8dc731bc104deb89fa322d
   

   The link to the revision 681b822618a0e89b4c8dc731bc104deb89fa322d

2. Once it is deployed, it will result in the following helm release in namespace ver1

3. Update the gitrepo with revision set to cfd907e5a17c386bf369736c798e0cac1e00e7e6

   Once deployed, a new helm release in namespace ver2 is now created, but the old release ver1 was not removed:

   

Environment

- Architecture: amd64
- Fleet Version: 0.8.1
- Cluster:
  - Provider: k3s
  - Options:
  - Kubernetes Version: 1.25
- Rancher Server: 2.7.9

Logs

2024-02-20T15:18:03.455296701Z time="2024-02-20T15:18:03Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063/fleet-agent-c-5nxhd"
2024-02-20T15:18:11.394409146Z time="2024-02-20T15:18:11Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063/github-issue-20240220-20240220"
2024-02-20T15:18:11.598912257Z time="2024-02-20T15:18:11Z" level=info msg="Helm: Installing github-issue-20240220-20240220"
2024-02-20T15:18:11.602673594Z time="2024-02-20T15:18:11Z" level=info msg="API Version list given outside of client only mode, this list will be ignored"
2024-02-20T15:18:11.843409739Z time="2024-02-20T15:18:11Z" level=info msg="getting history for release release1"
2024-02-20T15:18:11.861205408Z time="2024-02-20T15:18:11Z" level=info msg="getting history for release release1"
2024-02-20T15:18:12.033548310Z time="2024-02-20T15:18:12Z" level=info msg="Deploying bundl
e cluster-fleet-default-c-5nxhd-7df993ee2063/github-issue-20240220-20240220"
2024-02-20T15:18:12.189498498Z time="2024-02-20T15:18:12Z" level=info msg="preparing upgrade for release1"
2024-02-20T15:18:12.191634783Z time="2024-02-20T15:18:12Z" level=info msg="performing update for release1"
2024-02-20T15:18:12.191694287Z time="2024-02-20T15:18:12Z" level=info msg="dry run for release1"
2024-02-20T15:18:12.203339791Z time="2024-02-20T15:18:12Z" level=info msg="Helm: Upgrading github-issue-20240220-20240220"
2024-02-20T15:18:12.204087644Z time="2024-02-20T15:18:12Z" level=info msg="preparing upgrade for release1"
2024-02-20T15:18:12.262434173Z time="2024-02-20T15:18:12Z" level=info msg="performing update for release1"
2024-02-20T15:18:12.262540889Z time="2024-02-20T15:18:12Z" level=info msg="creating upgraded release for release1"
2024-02-20T15:18:12.275944142Z time="2024-02-20T15:18:12Z" level=info msg="updating status for upgraded release for release1"
2024-02-20T15:18:12.425567608Z time="2024-02-20T15:18:12Z" level=info msg="getting history for release release1"
2024-02-20T15:18:12.612470879Z time="2024-02-20T15:18:12Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063/github-issue-20240220-20240220"
2024-02-20T15:18:12.771898013Z time="2024-02-20T15:18:12Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063/github-issue-20240220-20240220"
2024-02-20T15:18:12.795607505Z time="2024-02-20T15:18:12Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063/github-issue-20240220-20240220"
2024-02-20T15:18:14.033874371Z time="2024-02-20T15:18:14Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063/github-issue-20240220-20240220"
2024-02-20T15:18:14.051284519Z time="2024-02-20T15:18:14Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063/github-issue-20240220-20240220"
2024-02-20T15:19:25.735929394Z time="2024-02-20T15:19:25Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063
/github-issue-20240220-20240220"
2024-02-20T15:19:25.939534603Z time="2024-02-20T15:19:25Z" level=info msg="Helm: Installing github-issue-20240220-20240220"
2024-02-20T15:19:25.943899914Z time="2024-02-20T15:19:25Z" level=info msg="API Version list given outside of client only mode, this list will be ignored"
2024-02-20T15:19:26.175934957Z time="2024-02-20T15:19:26Z" level=info msg="getting history for release release2"
2024-02-20T15:19:26.329999214Z time="2024-02-20T15:19:26Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063/github-issue-20240220-20240220"
2024-02-20T15:19:26.492463050Z time="2024-02-20T15:19:26Z" level=info msg="preparing upgrade for release2"
2024-02-20T15:19:26.495620400Z time="2024-02-20T15:19:26Z" level=info msg="performing update for release2"
2024-02-20T15:19:26.495841654Z time="2024-02-20T15:19:26Z" level=info msg="dry run for release2"
2024-02-20T15:19:26.514205798Z time="2024-02-20T15:19:26Z" level=info msg="Helm: Upgrading github-issue-20240220-20240220"
2024-02-20T15:19:26.515128810Z time="2024-02-20T15:19:26Z" level=info msg="preparing upgrade for release2"
2024-02-20T15:19:26.581621167Z time="2024-02-20T15:19:26Z" level=info msg="performing update for release2"
2024-02-20T15:19:26.581745763Z time="2024-02-20T15:19:26Z" level=info msg="creating upgraded release for release2"
2024-02-20T15:19:26.601568176Z time="2024-02-20T15:19:26Z" level=info msg="updating status for upgraded release for release2"
2024-02-20T15:19:26.901763366Z time="2024-02-20T15:19:26Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063/github-issue-20240220-20240220"
2024-02-20T15:19:27.543175539Z time="2024-02-20T15:19:27Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063/github-issue-20240220-20240220"
2024-02-20T15:19:28.330479221Z time="2024-02-20T15:19:28Z" level=info msg="Deploying bundle cluster-fleet-default-c-5nxhd-7df993ee2063/github-issue-20240220-20240220"

Anything else?

No response