elemental-toolkit icon indicating copy to clipboard operation
elemental-toolkit copied to clipboard

Autobumper should not add version if there is no version key

Open Itxaka opened this issue 2 years ago • 0 comments

cos-toolkit version: master

CPU architecture, OS, and Version: N/A

Describe the bug Currently we use anchors on the cos collection.yaml file to avoid repeating some of the stuff, including version numbers for all the different cos-whatever artifacts. This keeps the versions in sync, especially between the cos system and cos recovery, as they should always match,

Autobumper is adding version numbers to those entries and may desync them, so you end up with a recovery with a version and a system with another.

The contents are the same, so its not a big problem but it could lead to confusion, after a cos-reset of one of your nodes in a cluster it suddenly reports a different version number for example.

To Reproduce have a recovery with a different version number than your cos system, run cos-reset, check version number

Expected behavior Recovery and system to have the same version.

Logs Tests cached this https://github.com/rancher-sandbox/cOS-toolkit/runs/4097481553?check_suite_focus=true

Additional context

Itxaka avatar Nov 04 '21 08:11 Itxaka