Incorrect app bar cluster abbreviations

[richard-cox]

Setup

• Rancher version: pre 2.8.0

Describe the bug

• rc-rke1-3 and rc-rke1-4 both shorten to RR1 instead of RR3 and RR4

To Reproduce

• create imported clusters with names above
• view them in the new app bar

Result

Expected Result RR3 and RR4

[richard-cox]

In addition we should look at how these work

https://github.com/rancher/dashboard/blob/master/shell/utils/tests/cluster.test.ts#L36C1-L43C44

    ['customer-support-team-1', 'cst'],
    ['customer-support-team-one', 'cst'],
    ['customer-support-team-prod', 'cst'],
    ['customer-support-team-dev', 'cst'],
    ['customer-support-team-prod-1', 'cst'],
    ['customer-support-team-dev-1', 'cst'],
    ['customer-support-team-prod-2', 'cst'],
    ['customer-support-team-dev-2', 'cst'],

[richard-cox]

We should tackle https://github.com/rancher/dashboard/issues/9840 at the same time

[edenhernandez-suse]

For reference, here are the specs for the cases with & without cluster colour:

Adobe Xd Specs

[izaac]

I didn't spot a check for this test expectation:

• Opening the Customise modal, the Use custom badge & Apply buttons should be disable.

Let me know if I've missed it but I checked the e2e and I didn't find an is disabled assertion. @yonasberhe23

[gaktive]

@nwmac with @scures gone, can you answer this question from QA?

[richard-cox]

Opening the Customise modal, the Use custom badge & Apply buttons should be disable.

@izaac This has partially changed during the lifetime of the PR. the use custom badge should be enabled and the Apply button disabled. However this isn't working (when there are no setting the Apply button is enabled). I think there were some other changes we might make as well, so i createed a separate issue

[nwmac]

Thank you @richard-cox

[yonasberhe23]

I think it's safe to move this to done. test coverage is sufficient with e2e testing the modal functionality and unit testing the cluster abbreviations. @izaac