dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

RKE1 agent config e2e tests

Open mantis-toboggan-md opened this issue 2 years ago • 4 comments

Summary

Fixes #8828

~Requires Ember changes: https://github.com/rancher/ui/pull/5046~ merged

mantis-toboggan-md avatar Jun 30 '23 15:06 mantis-toboggan-md

This is ready to review, though passing ci e2e will require https://github.com/rancher/ui/pull/5046 to be merged

mantis-toboggan-md avatar Jul 27 '23 23:07 mantis-toboggan-md

Updated to address review comments, fix rke2 pod affinity weighted term spec, and fix vscode typescript intellisense

mantis-toboggan-md avatar Jul 31 '23 19:07 mantis-toboggan-md

Sorry, one more issue. Looks like the admin tests all pass, however it takes 39 minutes to run the new rke1 agent config tests. This is a bit long for CI. We have an issue to start splitting this stuff out into buckets (ci, nightly, etc) but there could be something wrong with the test itself. Could you take a look, see where the logjams are (page reloads usually take a while, tests may be flaky requiring multiple attempts, etc)

richard-cox avatar Aug 01 '23 11:08 richard-cox

Sorry, one more issue. Looks like the admin tests all pass, however it takes 39 minutes to run the new rke1 agent config tests. This is a bit long for CI.

It's definitely slower to load the ember iframed pages but that doesn't fully account for the run time. The only issue I was able to spot was super high memory use so I researched how I might ameliorate that. I was able to lower the test time to 11 minutes (admittedly still double the equivalent rke2 tests) by splitting each field of agent configs into their own describe block and setting NUM_TESTS_KEPT_IN_MEMORY to 0 ...I'm not confident I fully understand the implications of changing this setting, though.

mantis-toboggan-md avatar Jan 13 '24 01:01 mantis-toboggan-md

@mantis-toboggan-md Should we bump this to 2.11?

nwmac avatar Oct 25 '24 08:10 nwmac

@mantis-toboggan-md Time marches on and RKE1 has been removed, so I think this PR can be closed?

nwmac avatar Jul 02 '25 11:07 nwmac