dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Separate "advanced filtering" feature from Elemental PR

Open aalves08 opened this issue 3 years ago • 3 comments

  • Adds advanced filtering feature to Resource Table component

Screenshot/Video

These images show a test I did with catalog.cattle.io.app custom list resource with the advanced filtering feature working

Screenshot 2022-10-10 at 11 49 46 Screenshot 2022-10-10 at 11 49 50 Screenshot 2022-10-10 at 11 49 56

aalves08 avatar Oct 10 '22 12:10 aalves08

Codecov Report

Base: 36.88% // Head: 36.52% // Decreases project coverage by -0.36% :warning:

Coverage data is based on head (e3d8dd8) compared to base (bae50a2). Patch coverage: 11.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7134      +/-   ##
==========================================
- Coverage   36.88%   36.52%   -0.37%     
==========================================
  Files         986      987       +1     
  Lines       17633    17766     +133     
  Branches     4541     4576      +35     
==========================================
- Hits         6504     6489      -15     
- Misses      11129    11277     +148     
Flag Coverage Δ
e2e 46.84% <11.67%> (-0.59%) :arrow_down:
merged 36.52% <11.67%> (-0.37%) :arrow_down:
unit 5.17% <0.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
shell/components/ResourceList/index.vue 0.00% <ø> (ø)
shell/components/ResourceTable.vue 0.00% <ø> (ø)
shell/components/SortableTable/THead.vue 0.00% <ø> (ø)
shell/components/SortableTable/index.vue 0.00% <ø> (ø)
shell/mixins/advanced-filtering.js 10.41% <10.41%> (ø)
shell/components/SortableTable/filtering.js 15.90% <12.50%> (+1.36%) :arrow_up:
shell/store/type-map.js 71.32% <100.00%> (+0.03%) :arrow_up:
shell/mixins/metric-poller.js 77.77% <0.00%> (-22.23%) :arrow_down:
shell/plugins/steve/mutations.js 36.17% <0.00%> (-10.64%) :arrow_down:
shell/utils/poller.js 75.00% <0.00%> (-10.00%) :arrow_down:
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 12 '22 16:10 codecov-commenter

I haven't gone through the code of this PR in any detail, but I've run it against a harvester cluster and ensured that the table css changes don't cause issues there.

mantis-toboggan-md avatar Oct 12 '22 18:10 mantis-toboggan-md

  • work through the getValue issue from comments

Hello @richard-cox i've updated the PR with the latest changes taking into account your comments.

Label filter now working Screenshot 2022-10-14 at 16 41 39

Pods (apparently they don't use the custom list of workloads, so it's the default) Screenshot 2022-10-14 at 16 54 36 Screenshot 2022-10-14 at 16 55 07

🙏 🙇

aalves08 avatar Oct 14 '22 16:10 aalves08