dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

NetworkPolicy PolicyRules checkbox and buttons overlap

Open cnotv opened this issue 3 years ago • 4 comments

Setup

  • Rancher version:
  • Browser type & version:

Describe the bug

Create/edit of a NetworkPolicy the PolicyRules component overlaps the checkbox to add ingress or egress rules.

To Reproduce

  • Navigate to a cluster Network Policy (/c/local/explorer/networking.k8s.io.networkpolicy/create#ingress)
  • Toggle the checkbox

Result

Buttons overlap the checkbox

Expected Result

Buttons are below the checkbox.

Screenshots

https://user-images.githubusercontent.com/5009481/194338992-d7774825-8663-4355-898a-d49b5e89afce.mp4

Additional context

Possible fix (thanks @kwwii ) is to remove negative margin (margin: -20px;) from Tabbed component

Issue seems introduced with https://github.com/rancher/dashboard/issues/5734 with the topic https://github.com/rancher/dashboard/pull/6214

cnotv avatar Oct 06 '22 14:10 cnotv

/backport v2.6.9

slickwarren avatar Oct 06 '22 17:10 slickwarren

#7115 already has the backport work for 2.6.9 (since Dashboard doesn't have a bot). @slickwarren is there something that needs updating in that ticket?

gaktive avatar Oct 11 '22 16:10 gaktive

not at the moment that I know of, I tried that command before creating the ticket you linked.

slickwarren avatar Oct 11 '22 17:10 slickwarren

@gaktive https://github.com/rancher/dashboard/issues/7115#issuecomment-1273257579

cnotv avatar Oct 11 '22 17:10 cnotv

tested on v2.7-head (0dcfd16): there is no overlap observed in networkPolicy policyrules

slickwarren avatar Oct 17 '22 17:10 slickwarren