dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

NamespaceFilter: add Enter shortcut

Open torchiaf opened this issue 3 years ago • 2 comments

  • add Enter key shortcut in case of searching word returns exactly one result.
  • fix css

Signed-off-by: Francesco Torchia [email protected]

Summary

Fixes #5798

Areas or cases that should be tested

  • Namespaces Search box

torchiaf avatar Sep 29 '22 13:09 torchiaf

Was able to test the feature and it seems to work as expected. One thing that I noticed was that I could never enter the homepage properly... Got some issues with the CommunityLinks component (check screenshot). I think your branch might not be updated with the latest master on rancher/dashboard.

git remote add upstream [email protected]:rancher/dashboard.git
git fetch upstream
git rebase upstream/master

You should also check what backend version you are using as well as there's a new one out v2.7-head.

Otherwise, LGTM.

Let me know once this is resolved. Thanks! 🙏

Screenshot 2022-10-12 at 11 06 53

aalves08 avatar Oct 12 '22 10:10 aalves08

Was able to test the feature and it seems to work as expected. One thing that I noticed was that I could never enter the homepage properly... Got some issues with the CommunityLinks component (check screenshot). I think your branch might not be updated with the latest master on rancher/dashboard.

git remote add upstream [email protected]:rancher/dashboard.git
git fetch upstream
git rebase upstream/master

You should also check what backend version you are using as well as there's a new one out v2.7-head.

Otherwise, LGTM.

Let me know once this is resolved. Thanks! pray

Screenshot 2022-10-12 at 11 06 53

Thanks @aalves08 . It seems to be resolved after the rebase.

torchiaf avatar Oct 14 '22 08:10 torchiaf