dashboard
dashboard copied to clipboard
[Forward port] Azure AD Edit Config always picks Standard endpoint in radio button
Forward port https://github.com/rancher/dashboard/issues/6428
PR #7032
On v2.7-eab28ddaeeb
head
- Able to reproduce the issue.
- Configure Custom Endpoint. - Azure AD Auth
- Navigate to local cluster --> Users and Authentication --> Auth provider --> Edit Config
- Standard is selected.
Reopening the issue
Pushing to 2.7.1 since it's not completely required for this release. However, it sounds like there's no backend fix to be done, so @gaktive to work with @jordojordo on figuring out how to develop on this via some credentials.
I was not able to repro this on v2.7-a352c871a151f093a1f15898951317e177445c79-head
: I followed the instructions for enabling azuread with custom endpoints from the rancher docs, and the 'custom' radio option was correctly selected upon editing the auth config.
🚧 REOPENED
Reproduction Environment
docker install
Component | Version / Type |
---|---|
Rancher version | 2.7.1 |
Installation option | Docker |
Cert Details | --acme-domain |
Docker version | 20.10.7, build f0df350 |
Helm version | v2.16.8-rancher2 |
Downstream cluster type | not applicable |
Downstream K8s version | not applicable |
Authentication providers enabled | azure ad |
Logged in user role | admin |
Browser type | microsoft edge |
Browser version | 110.0.1587.50 |
🚨 Additional Reproduction Setup Details: Click to Expand
Env setup with: https://github.com/brudnak/linode-docker-cattle
Reproduction steps
- Enable AzureAD OAuth auth provider
- Starting from the default Rancher homepage
/dashboard/home
- Click
hamburger menu
>>>Users & Authentication
>>>Auth Provider
>>>AzureAD
- Click the radio button underneath
Endpoints
: >>>Custom
- Fill out all the fields
- Click
Enable
- Starting from the default Rancher homepage
- After enabling navigate back to the home screen
- Now navigate back to auth providers
- Click
Edit Config
- Observe the UI radio button is now set to standard and not custom
Additional Info
RESULTS
✅ Expected
For the setup process to be remembered and the radio button to still set as Custom
❌ Actual
Radio button when trying to edit the config was switched to Standard
Validation Environment
docker install
Component | Version / Type |
---|---|
Rancher version | v2.7-d559c2f16d5a634d8e5188e242ee9a5b69c55908-head |
Rancher commit link | https://github.com/rancher/rancher/commit/d559c2f16d5a634d8e5188e242ee9a5b69c55908 |
Installation option | Docker |
Cert Details | --acme-domain |
Docker version | 20.10.7, build f0df350 |
Helm version | v2.16.8-rancher2 |
Downstream cluster type | not applicable |
Downstream K8s version | not applicable |
Authentication providers enabled | azure ad |
Logged in user role | admin |
Browser type | microsoft edge |
Browser version | 110.0.1587.50 |
🚨 Additional Reproduction Setup Details: Click to Expand
Env setup with: https://github.com/brudnak/linode-docker-cattle
Validation steps
- Enable AzureAD OAuth auth provider
- Starting from the default Rancher homepage
/dashboard/home
- Click
hamburger menu
>>>Users & Authentication
>>>Auth Provider
>>>AzureAD
- Click the radio button underneath
Endpoints
: >>>Custom
- Fill out all the fields
- Click
Enable
- Starting from the default Rancher homepage
- After enabling navigate back to the home screen
- Now navigate back to auth providers
- Click
Edit Config
- Observe the UI radio button is now set to standard and not custom
Additional Info
RESULTS
✅ Expected
For the setup process to be remembered and the radio button to still set as Custom
❌ Actual
Radio button when trying to edit the config was switched to Standard
Instructions on where to find custom endpoints for your azure ad app can be found here https://ranchermanager.docs.rancher.com/how-to-guides/new-user-guides/authentication-permissions-and-global-configuration/authentication-config/configure-azure-ad
✅ PASSED
Reproduction Environment
Unable to repo as mentioned here: and when following linked doc. Passing on 2.7.1.
https://github.com/rancher/dashboard/issues/7045#issuecomment-1421475867
Validation Environment
Component | Version / Type |
---|---|
Rancher version | v2.7-7913e283ff90eebd1f8cc48860a6b410d72cd4dd-head |
Rancher commit link | https://github.com/rancher/rancher/commit/7913e283ff90eebd1f8cc48860a6b410d72cd4dd |
Installation option | Helm (high availability) |
RKE binary version used | v1.4.0 |
If Helm Chart k8s cluster | v1.24.6 |
Cert Details | Let's Encrypt / nginx |
Docker version | 20.10.7, build f0df350 |
Helm version | v2.16.8-rancher2 |
Downstream cluster type | not applicable |
Downstream K8s version | not applicable |
Authentication providers enabled | local |
Logged in user role | admin, standard user |
Browser type | Google Chrome |
Browser version | 111.0.5563.110 |
Validation steps
- Enable AzureAD OAuth auth provider
- Starting from the default Rancher homepage
/dashboard/home
- Click
hamburger menu
>>>Users & Authentication
>>>Auth Provider
>>>AzureAD
- Click the radio button underneath
Endpoints
: >>>Custom
- Fill out all the fields
- Follow doc for custom endpoint here: https://ranchermanager.docs.rancher.com/how-to-guides/new-user-guides/authentication-permissions-and-global-configuration/authentication-config/configure-azure-ad
- Click
Enable
- Starting from the default Rancher homepage
- After enabling navigate back to the home screen
- Now navigate back to auth providers
Additional Info
RESULTS
✅ Expected
For the setup process to be remembered and the radio button to still set as Custom
✅ Actual
The setup process was remembered and the radio button was still set as Custom