dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

UX FIX: Elements in the "Header dropdown" should not be displayed as a link

Open manuelecarlini opened this issue 3 years ago • 2 comments

Setup

  • Rancher version: 2.6
  • Browser type & version:

Describe the bug

The dropdown in the header bar shows different elements, but those are not link, we need to change the color and make it look like as menu items

Screenshot 2022-03-28 at 20 51 53

To Reproduce

Result

Expected Result

Screenshots

Additional context

Detailed Description

Context

manuelecarlini avatar Jun 21 '22 08:06 manuelecarlini

@manuelecarlini This is the old namespace/project chooser - can you take a look at the latest UI - I'm not sure what you were proposing we change.

nwmac avatar Jul 13 '22 15:07 nwmac

I think this might be mainly fixed but we should verify the presentation.

kwwii avatar Jul 19 '22 12:07 kwwii

@manuelecarlini can you provide a status update regarding this issue? I see it is in Review, but there is no associated PR to this ticket.

markusewalker avatar Aug 16 '22 15:08 markusewalker

While we wait for this issue to be addressed, here is the QA test plan:

TEST PLAN

  1. Setup Rancher and navigate to the UI in a browser.
  2. Navigate to Cluster Explorer > local.
  3. In the dropdown menu that says Only User Namespaces, click that and verify if elements in the dropdown appear as different elements and not links.

markusewalker avatar Aug 19 '22 17:08 markusewalker

For clarification, is this in the new UI or in the ember UI? I believe that this has been fixed in the new UI and doubt that it would be changed in the old one.

kwwii avatar Aug 23 '22 11:08 kwwii

@kwwii @gaktive circling back to this issue, can you please provide a PR where this has been addressed in the new UI so that QA can properly validate? If this has already been addressed, we can proceed forward with validating and closing this.

markusewalker avatar Sep 01 '22 23:09 markusewalker

I haven't found the PR, although I can confirm that in the latest version, the items in the nav aren't blue anymore: Screen Shot 2022-09-08 at 1 14 10 PM

catherineluse avatar Sep 08 '22 20:09 catherineluse

Thanks @catherineluse, I see the same as well. Considering this is a relatively smaller issue, I will go ahead and provide an official QA sign off in a new comment to validate this and close this issue.

markusewalker avatar Sep 08 '22 20:09 markusewalker

Validated that this is addressed in v2.6-head https://github.com/rancher/rancher/commit/f9001728bc8f0851ea5fea451cdce7cc04b473ec.

ENVIRONMENT DETAILS

  • Rancher install: Helm
  • Rancher version: v2.6-head https://github.com/rancher/rancher/commit/f9001728bc8f0851ea5fea451cdce7cc04b473ec
  • Browser: Chrome

TEST RESULT PASS

VERIFICATION STEPS

  1. Setup Rancher and navigated to the UI in a browser.
  2. Navigated to Cluster Explorer > local.
  3. In the dropdown menu that says Only User Namespaces, clicked that and validated that the elements in the dropdown appear as different elements and not links: image

markusewalker avatar Sep 08 '22 20:09 markusewalker