dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Visual indicator when selecting cilium and enabling Project Network Isolation on v2 clusters

Open paynejacob opened this issue 3 years ago • 3 comments

When a user is creating a new v2 cluster and they select the cilium CNI and enable Project Network Isolation there should be a popup in the form that informs the users that the ingress controller will not be able to route requests to pods on other nodes by default. Ideally we should link to the related documentation as well.

https://github.com/rancher/docs/issues/3868

paynejacob avatar Feb 11 '22 20:02 paynejacob

UX to be designed - a popup is probably too intrusive

nwmac avatar Feb 14 '22 09:02 nwmac

Popup was probably the wrong word, maybe more of a banner in the form. Similar to a bootstrap alert.

paynejacob avatar Feb 14 '22 17:02 paynejacob

Add an info alert with the information "Per default the ingress controller will not be able to route requests to pods on other nodes."

kwwii avatar Jul 19 '22 12:07 kwwii

This is on the 'Basics' tab for RKE2 cluster creation.

Change the 'Container Network' dropdown to 'cillium' and then check the 'Project Network Isolation'.

We need to add an info banner (text below) when the user has these two settings.

nwmac avatar Aug 31 '22 08:08 nwmac

QA TEST PLAN

  1. Setup Rancher, create a standard user and login as that user.
  2. Navigate to Cluster Management > Create.
  3. While provisioning a downstream RKE2 node driver cluster, perform the following:
    • Change Container Network to cilium in the Cluster Configuration block.
    • Check Project Network Isolation in the Cluster Configuration block.
  4. Validate if an info banner appears with these two settings checked.
  5. Un-check the Project Network Isolation button and validate if the info button disappears.
  6. Re-check the Project Network Isolation button, but change the Container Network to a different CNI; validate if the info button disappears.

markusewalker avatar Sep 29 '22 17:09 markusewalker

Validated that this is addressed in v2.7-head https://github.com/rancher/rancher/commit/40c390d79faef993e8509d545a4ed1e18a78a4de.

ENVIRONMENT DETAILS

  • Rancher install: Docker
  • Rancher version: v2.7-head https://github.com/rancher/rancher/commit/40c390d79faef993e8509d545a4ed1e18a78a4de
  • Browser: Chrome

TEST RESULT PASS

VERIFICATION STEPS

  1. Setup Rancher, created a standard user and login as that user.
  2. Navigated to Cluster Management > Create.
  3. While provisioning a downstream RKE2 node driver cluster, performed the following:
    • Changed Container Network to cilium in the Cluster Configuration block.
    • Checked Project Network Isolation in the Cluster Configuration block.
  4. Validated that an info banner appears with these two settings checked: Sep-29-2022 10-35-13
  5. Un-checked the Project Network Isolation button and validated if the info button disappears as seen in the above GIF.
  6. Re-checked the Project Network Isolation button, but changed the Container Network to a different CNI; validated that the info button disappears: Sep-29-2022 10-36-00

markusewalker avatar Sep 29 '22 17:09 markusewalker