dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

UI should use subchart defaults, if any, when installing/upgrading a chart

Open slickwarren opened this issue 4 years ago • 3 comments

on master-head e756276: Repro Steps:

  • deploy rancher
  • deploy downstream cluster large enough for longhorn and monitoring
  • install longhorn
  • install monitoring
    • use a statefulset for grafana when installing monitoring
    • do not enter any values for the statefulset Screen Shot 2021-06-24 at 1 14 32 PM

I expected this to break the monitoring install, but instead: monitoring will install and use default values from grafana, using longhorn as the PV. After further investigation, it appears there are defaults in the subchart, Grafana. However, even after the successful install, the values.yaml don't reflect the values used from the subchart (from the repro steps, values.yaml -> grafana -> size still read as null , even though the is working as expected and is using a 10Gi PV in longhorn)

We should populate subchart defaults in the UI when applicable. This is likely the case for other charts as well, as many of our v2 charts use subcharts on install.

slickwarren avatar Jun 24 '21 20:06 slickwarren

We'll need someone to repro this to understand more of what's happening here. Normally, helm doesn't allow for sub-chart defaults to be looked at; if it's internal, then it's not visible. But this may exist in our questions file and we're not translating this.

@slickwarren is this a regression?

gaktive avatar Jun 25 '21 16:06 gaktive

on 2.5.8, this same test case was breaking monitoring. It looks like the subchart defaults have been there for awhile. Based on this, it seems like rancher has recently started using the subchart values in this case.

slickwarren avatar Jun 25 '21 19:06 slickwarren

I'll file an item with the backend to see if we can populate charts with the sub-chart values that the UI has exposed.

gaktive avatar Jul 13 '21 17:07 gaktive

Need to check if this is still an issue. Clearly, the 3 year old version of me missed linking back to something here if there is a rancher/rancher ticket.

gaktive avatar Jul 17 '24 23:07 gaktive