dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Published 20 hours ago • verified publisher icon rancher

set harvester chart values in before save hook instead of saveOverride

Open mantis-toboggan-md opened this issue 5 months ago • 0 comments

Summary

Fixes #13894

Occurred changes and/or fixed issues

Technical notes summary

This PR moves the logic to generate a kubeconfig secret and set that as well as other chart values from saveOverride into a before save hook, so that the code runs before switching to the yaml view.

Areas or cases that should be tested

  1. Navigate to the cluster manager cluster list view and click create
  2. Select the harvester rke2 option
  3. Select a cloud credential and fill all required fields in the machine config section
  4. Open browser dev tools network tab and watch network requests
  5. Click edit as yaml
  6. Verify that a secret was created and referenced in the cluster yaml

Checklist

  • [x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • [x] The PR has a Milestone
  • [x] The PR template has been filled out
  • [x] The PR has been self reviewed
  • [x] The PR has a reviewer assigned
  • [x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • [x] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • [x] The PR has been reviewed in terms of Accessibility

mantis-toboggan-md avatar Jun 26 '25 16:06 mantis-toboggan-md