dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard
verified publisher icon rancher

Fleet 2.12 non-blocking issues

Open torchiaf opened this issue 6 months ago • 2 comments

Setup

  • Rancher version: 2.12-head
  • Rancher UI Extensions:
  • Browser type & version:

Describe the bug

  • [x] ValuesFrom Remove button is not removing the correct row. See https://github.com/rancher/dashboard/pull/14525#issuecomment-2989074576
  • [x] Missing HelmOps headers in Resource -> HelmOps table
  • [x] Force Update action to be removed as not required in HelmOps context
  • [x] GitRepo list shows github icon; it should be replaced with Git icon.
  • [ ] When creating new HelmOps, the UI add the unknown helm.spec.namespace field in HelmOp payload
  • [ ] When creating new HelmOps, the UI add the unknown type field in App Bundles payload
  • [x] missing fleet.cluster.label in dashboard -> slide-in -> ResourceDetails component -> Cluster selector
  • [x] Pie charts in Fleet Dashboard should have a size of 52x52px with an inner radius (the coloured part) of 12px.
  • [x] View Mode button and Collapse button are inverted. To add the chevron-icons in Collapse button.
  • [ ] Improve GitRepo's Subpaths and App Bundles Target clusters layouts
  • [ ] Dashboard -> tooltip and text for In Progress resource is wrong in Pie Charts
  • [ ] Fix Fleet Settings accessibility
  • [ ] Remove the additional line at the bottom of workspace details page

Dashboard / App bundle details side drawer

  • [x] Cluster select inside App bundle details drawer has a broken label
  • [x] App bundle details drawer title should be an h3 for accessibility, and Source and Resources should be h4
  • [x] Branch @ commit text should have the same colour as input labels (our subheader color in the DS)

To Reproduce

Result

Expected Result

Screenshots

Additional context

torchiaf avatar Jun 20 '25 07:06 torchiaf

Adding something here because it requires a screenshot: the Cluster dropdown inside the drawer has a broken label

Image

edenhernandez-suse avatar Jun 25 '25 14:06 edenhernandez-suse

Workspace' details, line at the bottom:

Image

torchiaf avatar Jun 27 '25 08:06 torchiaf

Needs some quick manual visual checks.

izaac avatar Jul 22 '25 18:07 izaac

Rancher version: v2.12.0-rc2 Rancher UI version: v2.12.0-rc2 (Prime UI)

Almost all was validated as pass, there's an small discrepancy in one of the items in the checkboxes of the description

Pie charts in Fleet Dashboard should have a size of 52x52px with an inner radius (the coloured part) of 12px. -Fixed by https://github.com/rancher/dashboard/pull/14655

The canvas size is actually 62x62. I see a margin between the pie chart and the edge of the canvas, so that could be what I am observing, but I wanted to confirm before moving to close or reopen.

Image

izaac avatar Jul 26 '25 05:07 izaac

This is fine, @izaac, the library generates a canvas of 62px, but it has 5px of padding between the borders and the chart shape, so the charts end up with 52px. It will be changed in 2.13 to align it with the new 8pt grid, but for now it's totally fine.

edenhernandez-suse avatar Jul 28 '25 09:07 edenhernandez-suse

Thanks for the clarification @edenhernandez-suse. Moving to done.

izaac avatar Jul 29 '25 15:07 izaac