dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Can't use label `cattle.io/` on GitRepos on Rancher 2.9

Open mmartin24 opened this issue 1 year ago • 4 comments

Setup

  • Rancher version: v2.9-03e149351b6877d02ffe6f32be8b896708132f08-head
  • Rancher UI Extensions:
  • Browser type & version: Brave v1.66.118

Describe the bug Attempting to use cattle.io/) as label in Rancher 2.9will make disappear the box. (Note this is working in 2.8-head)

To Reproduce

  • Deploy Rancher 2.9-head
  • Go to Continuous Delivery > Git Repos > fleet-local > Add Repository
  • Give a name to the Git Repo
  • Click "Next"
  • Click "Add Label"
  • Under Key box type cattle.io/

Result Box disappears and that value cannot be added

Expected Result Box should not disappear ~~and should be possible to add this value~~

Screenshots

Screencast from 13-06-24 18:07:16.webm

Additional context

mmartin24 avatar Jun 13 '24 16:06 mmartin24

labels and annotations containing cattle.io are system only and are hidden. We have an issue to open up the view side to more resources #11222, however i don't think this will be extended to edit.

the input fields should not disappear though, and should not allow the user to add them

richard-cox avatar Jun 13 '24 16:06 richard-cox

labels and annotations containing cattle.io are system only and are hidden. We have an issue to open up the view side to more resources #11222, however i don't think this will be extended to edit.

the input fields should not disappear though, and should not allow the user to add them

mmm, ok so actually is invalid in 2.8.4 as well. It is simply not visible until you click Create image

mmartin24 avatar Jun 13 '24 16:06 mmartin24

Ok, let's keep the issue then if you agree to fix the disappearing field

mmartin24 avatar Jun 13 '24 16:06 mmartin24

Added this related issue: https://github.com/rancher/dashboard/issues/11242

mmartin24 avatar Jun 14 '24 14:06 mmartin24

Root issue https://github.com/rancher/dashboard/issues/13655

richard-cox avatar Jun 06 '25 08:06 richard-cox

/backport v2.11.4

torchiaf avatar Jul 03 '25 20:07 torchiaf

/backport v2.10.8

torchiaf avatar Jul 03 '25 20:07 torchiaf

/backport v2.9.11

torchiaf avatar Jul 03 '25 20:07 torchiaf

There are unit tests and the coverage seems enough to validate the fix

izaac avatar Jul 21 '25 16:07 izaac