dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard
verified publisher icon rancher

ColorInput width is broken after visiting Branding Page

Open richard-cox opened this issue 1 year ago • 2 comments

Setup

  • Rancher version: pre 2.9.0

Describe the bug

  • See screenshots
  • Branding page - shows wide area for colour, instead of small block colour then colour hash
  • Brand page - after visiting the branding page, block colour extends to max width

To Reproduce

  • visit branding page, see issue
  • then visit banners page, see issue

Result

  • as per screenshots

Expected Result

  • all colour pickers should look like the bottom screenshot

Screenshots Branding Page image

Banners Page (after visiting brancing page) image

Banners Page (without visiting brancing page) image

Additional context

  • caused by unscoped style block brought in via https://github.com/rancher/dashboard/pull/10502

richard-cox avatar May 22 '24 12:05 richard-cox

@torchiaf Do you recall why the styling here - https://github.com/rancher/dashboard/pull/10502/files#diff-ad9b69088ee28dda5c04184c22a48c81bbfc5d19b0c87f087342861aac7f078cR602 - is not scoped?

nwmac avatar May 22 '24 13:05 nwmac

Ah sorry for the regression. IIRC , there was an issue showing the background images in the correct position. Removing the scope fixed the issue but introduced this regression. I will take a look. @nwmac

torchiaf avatar May 22 '24 15:05 torchiaf