dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

AKS - fix container monitoring checkbox

Open mantis-toboggan-md opened this issue 1 year ago • 0 comments
trafficstars

Summary

Fixes #10965

Occurred changes and/or fixed issues

The 'container monitoring' checkbox should correspond to aksConfig.monitoring - previously it was just gating the visibility of the two log analytics inputs. This PR corrects that and adds a few unit tests.

Areas or cases that should be tested

  1. create an AKS cluster with container monitoring enabled, and log analytics workspace name/group set - the payload should include aksConfig.monitoring = true
  2. edit cluster and disable container monitoring - the payload should include aksConfig.monitoring = false, and aksConfig.logAnalyticsWorkspaceName and aksConfig.logAnalyticsWorkspaceGroup set to null

Checklist

  • [x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • [x] The PR has a Milestone
  • [x] The PR template has been filled out
  • [x] The PR has been self reviewed
  • [x] The PR has a reviewer assigned
  • [x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • [x] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

mantis-toboggan-md avatar May 21 '24 21:05 mantis-toboggan-md