dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard
verified publisher icon rancher

Add vGPU allocatable warning banner

Open torchiaf opened this issue 1 year ago • 5 comments

Summary

Fixes https://github.com/rancher/dashboard/issues/10989

Occurred changes and/or fixed issues

It adds a banner to provide guidelines about vGPUs allocation.

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

image

Checklist

  • [x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • [x] The PR has a Milestone
  • [x] The PR template has been filled out
  • [x] The PR has been self reviewed
  • [x] The PR has a reviewer assigned
  • [x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • [x] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

torchiaf avatar May 13 '24 13:05 torchiaf

@torchiaf I checked with @ibrokethecloud and it seems the value is not accurate (or even updated): https://github.com/harvester/harvester/issues/5774, should we wait for this ticket to be fixed first?

bk201 avatar May 20 '24 07:05 bk201

@bk201 We can wait for the backend issue to be solved first.

torchiaf avatar May 27 '24 12:05 torchiaf

@torchiaf Code looks good - is this required for 2.9.0? Looks like the harvester issue mentioned is still open.

nwmac avatar Jun 27 '24 08:06 nwmac

@nwmac I'm checking with Harvester team.

torchiaf avatar Jun 27 '24 12:06 torchiaf

Confirming that https://github.com/harvester/harvester/issues/5774 is blocker for the banner.

torchiaf avatar Jul 02 '24 10:07 torchiaf

Sorry @a110605, I fixed the wording a bit an dismissed your review.

jordojordo avatar Aug 14 '24 18:08 jordojordo

Sorry @a110605, I fixed the wording a bit an dismissed your review.

Hi @jordojordo , thanks for pushing the typo fix.

But this PR need wait for https://github.com/rancher/dashboard/pull/11399 merge first as last time I synced with Francesco.

a110605 avatar Aug 15 '24 06:08 a110605