dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

"Roles not created by" may be incorrect

Open lindhe opened this issue 1 year ago • 2 comments

When adding a new group under "Users & Authentication > Groups", there is a list of roles that says "Roles not created by {vendor}":

https://github.com/rancher/dashboard/blob/fec4ca64b73e2eb2fa0fee1b8d857c834e3c6537/shell/assets/translations/en-us.yaml#L4606

image

This, to me, sounds backwards. This is a custom role that I created. Should the "not" be removed here?

lindhe avatar Jan 19 '24 17:01 lindhe

I think this was originally meant to be "Rancher", to distinguish them from original, built in roles.

We would need to review if that sentiment should stay and if so not reference the vendor string.

richard-cox avatar Jan 19 '24 20:01 richard-cox

Worth noting: I've customized the name of my system, so it does not say Rancher. That makes it even weirder, since its really my customized system it's talking about: "Roles not created by Foo".

lindhe avatar Jan 19 '24 21:01 lindhe