charts icon indicating copy to clipboard operation
charts copied to clipboard

[dev-v2.9] elemental 104.0.0+up1.4.3 update

Open fgiudici opened this issue 9 months ago • 1 comments

Issue:

https://github.com/rancher/elemental-operator/issues/698

Problem

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

fgiudici avatar May 08 '24 10:05 fgiudici

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31696

Jirabot Action Result: Workflow Transition: Merge Pending Updated PR

github-actions[bot] avatar Apr 26 '24 14:04 github-actions[bot]

@g-pan @JamesDeFabia - Currently we swap out the ECL text with the ECL Editor control based on this selection:
"pre.programlisting:not([lang]),pre.programlisting[lang='ecl']"

I have added a button to open the ECL in the ECL Playground - but I think we said this should only be enabled for "some" of the ECL samples? So those samples need to be marked with another attribute so that I can optionally add the button as needed.

Note: This is a very quick implementation for now.

GordonSmith avatar Apr 26 '24 15:04 GordonSmith

@GordonSmith
We have already implemented an attribute for that purpose. We use the lang attribute to identify the language (ECL, CPP, bash, etc.) the role="runnable" indicates it will run as is on play.hpccsysems.com. (IOW, no other attribute or file is needed). Example:

JamesDeFabia avatar Apr 26 '24 16:04 JamesDeFabia

@JamesDeFabia can you point me to one of the files that has role set and I can use it for testing - thx.

GordonSmith avatar Apr 26 '24 16:04 GordonSmith

@GordonSmith Here are a few. In the HPCC-Platform/docs/EN_US/ECLLanguageReference/ECLR_mods folder: BltInFunc-AVE.xml BltInFunc-ASIN.xml Recrd-DICTIONARY.xml

JamesDeFabia avatar Apr 26 '24 16:04 JamesDeFabia