charts icon indicating copy to clipboard operation
charts copied to clipboard

Fix ksm/kubelet metricRelabeling issues.

Open hansbogert opened this issue 1 year ago • 11 comments

Issue:

rancher/rancher#43402

Problem

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

Unsure

hansbogert avatar Jun 19 '23 09:06 hansbogert

This PR also addresses issue rancher/rancher#43396

danielpalstra avatar Sep 14 '23 08:09 danielpalstra

This is still a problem for us that seems relatively easy to solve. Could someone please take the time to look at this PR?

staerion avatar Oct 18 '23 06:10 staerion

Hello @hansbogert Is this Pull Request still relevant? Can I close it?

nicholasSUSE avatar Feb 07 '24 22:02 nicholasSUSE

@nicholasSUSE @hansbogert and I can’t check if this is still relevant, because we stopped(many bugs) with using this chart. Maybe that other people still need this fix like @staerion.

nickvth avatar Feb 08 '24 06:02 nickvth

@nicholasSUSE @hansbogert and I can’t check if this is still relevant, because we stopped(many bugs) with using this chart. Maybe that other people still need this fix like @staerion.

Thank you. @staerion could you take a look at this?

nicholasSUSE avatar Feb 14 '24 17:02 nicholasSUSE

I suggest to close this PR.

recena avatar Feb 14 '24 21:02 recena

I suggest to close this PR.

I agree, I will wait for @staerion response before closing it.

nicholasSUSE avatar Feb 14 '24 21:02 nicholasSUSE

This PR is modifying rancher-kube-state-metrics but this chart does not exist anymore in dev-v2.7.

@recena @nicholasSUSE rancher-monitoring involves several sub-charts, kube-state-metrics is absolutely still an integral part of v2.7, I'd prefer if @joshmeranda and I take over the review of this one, since we are the team managing this line of features

alexandreLamarre avatar Feb 15 '24 17:02 alexandreLamarre

I am going to second @alexandreLamarre here. We are probably better suited for this

joshmeranda avatar Feb 15 '24 17:02 joshmeranda

I am going to second @alexandreLamarre here. We are probably better suited for this

@alexandreLamarre @joshmeranda thank you for your response.

nicholasSUSE avatar Feb 15 '24 20:02 nicholasSUSE

Is is still broken?

michisee avatar May 28 '24 09:05 michisee