backup-restore-operator icon indicating copy to clipboard operation
backup-restore-operator copied to clipboard

V2 Add ingress to networkpolicy allow all

Open r2ronoha opened this issue 1 year ago • 15 comments

r2ronoha avatar May 24 '23 07:05 r2ronoha

@eliyamlevy @superseb the unit tests seem to be "broken" rather than an issue with the change itself

Error: unknown flag: --helm3
Usage:
  unittest [flags] CHART [...]

r2ronoha avatar May 24 '23 09:05 r2ronoha

This requires https://github.com/rancher/backup-restore-operator/pull/320 to be backported

superseb avatar May 24 '23 10:05 superseb

This requires #320 to be backported

Do you know when that will be done?

r2ronoha avatar May 24 '23 10:05 r2ronoha

@r2ronoha From what I know we're not cutting a new version of the release/v2.0 line this quarter. I can look into bringing this in for the next. Also if you would please write some context as to why you want this change (your pr) merged that would be great.

eliyamlevy avatar May 24 '23 15:05 eliyamlevy

if you would please write some context as to why you want this change (your pr) merged that would be great.

The policy missing the ingress attribute blocks all ingress traffic, as opposed to allow (as the policy is intended to do). We are currently using a Kustomize override to add it, as it breaks access from the rest of the cluster to the resources in the namespace.

r2ronoha avatar May 25 '23 07:05 r2ronoha

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

github-actions[bot] avatar Jul 25 '23 02:07 github-actions[bot]

@r2ronoha From what I know we're not cutting a new version of the release/v2.0 line this quarter. I can look into bringing this in for the next. Also if you would please write some context as to why you want this change (your pr) merged that would be great.

This is still active. Waiting for release/v2.0 as per comment above

r2ronoha avatar Jul 27 '23 06:07 r2ronoha

Hello, please work on getting the build to pass if you choose to develop it yourself.

EDIT: Just saw the aboe comment, got swamped with other things I'll bring this up and see

eliyamlevy avatar Aug 07 '23 19:08 eliyamlevy

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

github-actions[bot] avatar Oct 07 '23 02:10 github-actions[bot]

still relevant

r2ronoha avatar Oct 20 '23 07:10 r2ronoha

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

github-actions[bot] avatar Dec 21 '23 02:12 github-actions[bot]

still relevant

r2ronoha avatar Jan 03 '24 07:01 r2ronoha

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

github-actions[bot] avatar Mar 04 '24 02:03 github-actions[bot]

Could you rebase this PR off the release/v4.0 branch?

And also please explain why this PR is needed, as there's no associated issue.

What difference would I observe with this change in place, and how would I trigger it?

ericpromislow avatar Mar 04 '24 20:03 ericpromislow

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

github-actions[bot] avatar May 05 '24 02:05 github-actions[bot]