rancher-desktop icon indicating copy to clipboard operation
rancher-desktop copied to clipboard

Add a toggle switch for muting diagnostics

Open rak-phillip opened this issue 2 years ago • 1 comments

This adds a toggle switch for toggling the display of muted diagnostics.

Examples

Screen Shot 2022-08-22 at 12 38 12 PM Screen Shot 2022-08-22 at 12 38 06 PM Screen Shot 2022-08-22 at 12 38 00 PM

closes #2656

rak-phillip avatar Aug 16 '22 23:08 rak-phillip

I should just mention that later on, when we have something similar to settings.json toggling the muted state on a diagnostic will need to be pushed to ipcMain to store that muted state with every reported diagnostic. When a diagnostic is no longer failing, it should be removed from that settings file.

ericpromislow avatar Aug 24 '22 20:08 ericpromislow

Presumably actually persisting the muted state will be in a future PR.

This is correct, we don't really have a mechanism on the backend for storing results at the moment, everything is in a static yaml file.

It would be good if the column width for Category is fixed; currently, if you mute the Networking diagnostic (leaving the Utilities ones), then hiding diagnostics causes the whole table to shift. But that's a paper cut.

This is a great call out! I added widths to the Documentation, Category, and Mute columns to reduce the amount of jitter when transitioning between states.

rak-phillip avatar Aug 26 '22 20:08 rak-phillip