yfinance icon indicating copy to clipboard operation
yfinance copied to clipboard

Fix Offset

Open R5dan opened this issue 8 months ago • 6 comments

This is a temp fix and should be replaced ASAP.

R5dan avatar May 03 '25 22:05 R5dan

@ValueRaider temp fix for #2419

R5dan avatar May 03 '25 22:05 R5dan

@ValueRaider can this be merged? It is a major bug.

R5dan avatar May 04 '25 18:05 R5dan

You forget that the predefined queries have predefined attributes e.g. sort. Better fix #2440

(also why are my commits in this commit history?)

ValueRaider avatar May 04 '25 19:05 ValueRaider

The post_query.update(PREDEFINED_SCREENER_QUERIES[query]) adds all of the predefined attributes.

(I dont know why your commits are in this)

R5dan avatar May 04 '25 20:05 R5dan

I could also change it to

query = PREDEFINED_SCREENER_QUERIES[query].copy()
query.update(fields)
post_query = query

This would keep the customized inputs.

R5dan avatar May 04 '25 21:05 R5dan

@ValueRaider have you decided which one to merge?

R5dan avatar May 06 '25 07:05 R5dan

Decided, merged mine.

ValueRaider avatar May 11 '25 12:05 ValueRaider