viewflow-rest icon indicating copy to clipboard operation
viewflow-rest copied to clipboard

Bugs may have been found

Open m3r3lin opened this issue 1 year ago • 1 comments

please check this line :

https://github.com/ramwin/viewflow-rest/blob/74a1f86f530329fc452dae356a95746e096197dc/viewflow_rest/activations.py#LL263C13-L263C22

It should change as follows:

task = get_or_create_task(
            flow_class.task_class,
            process=prev_activation.process,
            flow_task=flow_task.name,
            previous=prev_activation.task
        )

or this lines:

https://github.com/ramwin/viewflow-rest/blob/74a1f86f530329fc452dae356a95746e096197dc/viewflow_rest/activations.py#LL379C1-L383C18

maybe change as follows:

self.flow_class.task_class._default_manager.filter(
    process=self.process,
    status=STATUS_CHOICE.DONE,
    flow_task=incoming_edge.src.name,
).latest('id')

Because in the following process, if the condition of the last step is not true and it returns to the step before joining, it will give an error that there is more than one task and it is not possible with the get() operation.

image

m3r3lin avatar Jun 14 '23 12:06 m3r3lin