uuid icon indicating copy to clipboard operation
uuid copied to clipboard

feat: Support brick/math v0.12

Open siketyan opened this issue 9 months ago • 3 comments

Closes #525

Description

This pull request adds support for brick/math v0.12.

Motivation and context

brick/math v0.12 has been released. ramsey/uuid requires < 0.12 for now, so we can not upgrade brick/math until ramsey/uuid supports it.

How has this been tested?

Static Analysis + Unit Tests

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING.md document.
  • [ ] I have added tests to cover my changes.

siketyan avatar Nov 30 '23 03:11 siketyan

This issue blocks our upgrade because we use another package requiring brick/math 0.12+. Is there anything I can do to help to make this merged?

MartinMystikJonas avatar Jan 08 '24 17:01 MartinMystikJonas

Sorry for the delay. I've been dealing with some rough issues in my personal life, most notably, I'm unemployed at the moment, so every waking hour is spent job-searching, and I haven't had time for open source contributions. I will try to revisit this and merge and release it as soon as I can, but it might still be a while. Thank you for your patience!

ramsey avatar Jan 17 '24 01:01 ramsey

@ramsey any updates on this issue?

nijholt avatar Jan 31 '24 09:01 nijholt

Hi @ramsey - hope all is well with you. Is there anything we can do to help get this one over the line? It's a showstopper for multiple projects for me that need to be using Brick/Money which requires Brick/Math 0.12+. Thanks!

betterthanclay avatar Mar 19 '24 10:03 betterthanclay

@ramsey Hope you are doing well. Hoping to merge this one soon. If there is anything we can do, let us know. Thank you.

emielmolenaar avatar Mar 29 '24 09:03 emielmolenaar

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.64%. Comparing base (d459bdb) to head (163767b). Report is 15 commits behind head on 4.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                4.x     #526   +/-   ##
=========================================
  Coverage     95.64%   95.64%           
  Complexity      583      583           
=========================================
  Files            70       70           
  Lines          1560     1560           
=========================================
  Hits           1492     1492           
  Misses           68       68           
Files Coverage Δ
src/Math/BrickMathCalculator.php 100.00% <100.00%> (ø)

codecov[bot] avatar Apr 27 '24 21:04 codecov[bot]

Thank you for contributing! 🎉

ramsey avatar Apr 27 '24 21:04 ramsey