uuid icon indicating copy to clipboard operation
uuid copied to clipboard

Added Uuid:FromHexadecimal() and enhanced Uuid:FromString()

Open pluk77 opened this issue 4 years ago • 5 comments

As requested.

I opted to re-use FromString in FromHexadecimal as that would catch any short Heexadecimal numbers.

pluk77 avatar Apr 08 '20 11:04 pluk77

Is there anything else you need from me before you can consider this for inclusion in your bundle?

pluk77 avatar Oct 21 '20 12:10 pluk77

I've been swamped lately, so I haven't had a chance to get back to this. Are you able to resolve the failures? If so, I can go ahead and merge this. If not, it will need to wait until I have some time to fix them.

Thanks!

ramsey avatar Oct 22 '20 15:10 ramsey

I don't think I can resolve these failures as some originate form the fact the the new method can not be added to the uuidFactoryInterface for BC purposes. I will wait patiently for you to have some time.

pluk77 avatar Oct 27 '20 08:10 pluk77

Codecov Report

Merging #309 (538e1b0) into 4.x (9fd59bb) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 538e1b0 differs from pull request most recent head 0078302. Consider uploading reports for the commit 0078302 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                4.x     #309      +/-   ##
============================================
+ Coverage     95.55%   95.57%   +0.01%     
- Complexity      581      584       +3     
============================================
  Files            70       70              
  Lines          1554     1561       +7     
============================================
+ Hits           1485     1492       +7     
  Misses           69       69              
Impacted Files Coverage Δ
src/Uuid.php 97.02% <100.00%> (+0.15%) :arrow_up:
src/UuidFactory.php 98.36% <100.00%> (+0.02%) :arrow_up:

codecov[bot] avatar Oct 29 '20 23:10 codecov[bot]

@ramsey How is your workload at the moment? Would you be able to look at the failed integration test as it seems like it can only be resolved by adding the function to the factory interface and thereby breaking backwards compatibility.

pluk77 avatar Sep 07 '21 06:09 pluk77