devtools-lib icon indicating copy to clipboard operation
devtools-lib copied to clipboard

fix: add missed isTtySupported() method

Open upyx opened this issue 3 years ago • 0 comments

Fixes fatal error #90 by adding missed isTtySupported() method.

Description

It copies the isTtySupported() static method from Symfony's Process to the abstract ProcessCommand. Additionaly it excluded Composer >=2.3 from composer.json and removed the deprecated totallyTyped Psalm option.

Motivation and context

Version 1.3.0 doesn't work with PHP 8. Version 1.4.0 doesn't work at all. I'd like to use devtools with PHP 8. Fixes #90

How has this been tested?

composer self-update --2.2
composer update
bin/devtools test:all
$ php --version
PHP 8.1.4 (cli) (built: Mar 29 2022 01:58:57) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.4, Copyright (c) Zend Technologies

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING.md document.
  • [ ] I have added tests to cover my changes.

upyx avatar Apr 07 '22 06:04 upyx