collection icon indicating copy to clipboard operation
collection copied to clipboard

Add Doctrine ArrayCollection::partition() like

Open benjaminmal opened this issue 4 years ago • 1 comments

Is your feature request related to a problem? Please describe.

Yes, when I need to split a CollectionInterface in two, I have to use CollectionInterface::filter twice with opposite callbacks, which is not very efficient.

Describe the solution you'd like

I found out that Doctrine ArrayCollection is using a partition method which doesn't itinerate twice in the collection. So it could be very useful to have this method in this project! I can submit a PR if needed.

Describe alternatives you've considered

I am not sure if it is better to implement the method in ArrayInterface or CollectionInterface (and related abstract method of course). What do you think?

Additional context

Or maybe there is a way to do the same without modifying the project?

Thanks

Thanks for your work ;)

benjaminmal avatar Jun 29 '20 16:06 benjaminmal

Collections are iterable so you can already loop once and manually build 2 new collections. I agree, a partition function (on collectioninterface imo) would make it look nicer though.

SimoTod avatar Jul 01 '20 08:07 SimoTod