Ramsay
Ramsay
After rereading the Spotify's document, I think its explanation about the restriction between `filter` and `result type` is ambiguous, so I think it's better to leave `filter` and `result type`...
In my opinion, there are two ways to test the `SearchQuery` builder. > I can't just call the method into and compare the result to an expected query string because...
The pipeline complained about that it's unable to find the definition of `SearchQuery`, so you should `import` the `SearchQuery` before using it: ```rust /// Exemple /// ```rust /// use SearchQuery;...
Hi Thomas, thanks for your suggestion, I think your point makes sense and reasonable, this library introduces some breaking API changes, so it shouldn't be a minor version increase, and...
Closing this issue since the v0.11.7 has been yanked.
This API is not implemented yet, and PR is definitely welcome :)
You could take the [`current_playing`](https://github.com/ramsayleung/rspotify/blob/master/examples/auth_code.rs) endpoint for example, test your new endpoint by 1. Add an example file 2. Add an [entry](https://github.com/ramsayleung/rspotify/blob/master/Cargo.toml#L94) in cargo.toml 3. Run your example with `cargo`:...
The example acts like an end-to-end test for the new endpoint, because as we discussed in this issue: https://github.com/ramsayleung/rspotify/issues/154#issuecomment-1699115854, there is no workable approach for us to run unit test.
Good point! > provide a callback function that could be called when the token is refreshed It's a great idea, and in order to keep compatibility and doesn't affect the...
> I think it may be better to have this be a breaking change rather than try to keep the previous behaviour of reading/writing the token. > To me it...