Bump multiverse to latest, fix various bugs and improve performance
Changes
- Bump package version to
5.0.0 - Update to latest Multiverse by HTML5 UP (updated on:
07/03/2022)- Available for download at: https://html5up.net/multiverse
- This bumps jQuery and other js / css files etc
- Bumps Font Awesome to
v5.15.4 - Removes explicitly ie8/ie9 support
- Bump jekyll & github-pages in Gemfile
- Remove
webrickfrom Gemfile (seems unused?) - Remove
ads.txt(seems unused?) - Reapply Ram's dynamic caption fix to
jquery.poptrox.modified.js(based onv2.5.2-dev) - Change gulpfile to be a module (
.mjs) - Update gulp to minify all JS & CSS files automatically
- Reorder
_config.ymland use full classnames likefa fa-camera-retrofor font-awesome v5 icons. This is needed because in v5+ the icons are in different groups based on style. - Defer all footer scripts for improved load performance.
- Preload font-awesome and fonts in header to make it non-blocking (no CSS
@import) - Set
is-preloadin default.html to prevent initial page load flicker (fixes #114 )
Screenshot
Review notes
- Can you confirm if
webbrickin Gemfile is used for anything - Can you confirm if
ads.txtwas needed for anything - Note that
jquery.poptrox.jsis the minified variant. I have contacted @ajlkn from (https://github.com/ajlkn/jquery.poptrox) to see if he will share unminified version ofv2.5.2-dev - ie8/ie9 support is no longer there (because of multiverse update). I feel this is fine but if you disagree its a blocker for this PR.
- Unrelated to this PR but the
Presentifysponsor logo url is broken (because the Github signature probably expired). You can fix that in a different PR. - Otherwise, please test these changes yourself. I am using these changes on https://photos.mobeigi.com without issues.
CC: @rampatra
Okay, I will make some slight changes and approve. But it would be great if you can keep the functionality of the website same as before like the forms, etc. A few folks have said it earlier that it's helpful as one can easily plug that form to a form handler saas without much coding so in those cases it's quite handy. Yea, ads.txt was recommended by Google Ads but we do not need it now as there are no Google Ads shown. Thanks for removing it.
Also, I do not understand why/how the spacing between the "Sponsor" section and the "Follow me on..." section is now gone. (from your screenshot attached)
Sure thing we can add the contact form back in. Let me know if you are doing it as part of your changes or I can to.
I'm not sure why the spacing may have broken for that section (maybe the new .css). I'll check it later when I have some time to find out why.
Hey Ram,
I made the following changes:
- Restored the email form to what it looked like before
- Fixed the
sponsorandfollow me onspacing. It was caused by some missing custom CSS for the footer I forgot to copy across in my changes. I added this to acustom.scssfile that is compiled with gulp and used rather than changing multiverse files directly (to allow easier future updates). - Author of poptrox emailed me original
jquery.poptrox.js v2.5.2-devso I included the original in source code
Tested and working well on my end. See updating screenshot in original post.
Hey @rampatra,
Let me know if you have a chance to review the above changes when you are not busy 👍
@rampatra Any chance this can be merged? Its basically good to go. Been running it live for 2 months now with no issues.
@rampatra can we consider these additions? These look great and fix up a lot of the older versions :)
@add1ct3dd Yeah, I have been using these changes in my own fork for over a year now. They've been working great!
Just need @rampatra to review & merge this is so everyone else can benefit too.
All other changes look good to me. Once my last comment is answered, I can go ahead and merge this.