oauth2-rs icon indicating copy to clipboard operation
oauth2-rs copied to clipboard

Update to ureq 3

Open softdevca opened this issue 9 months ago • 5 comments

Simple update to ureq version 3, no changes required except for Cargo.toml

softdevca avatar Mar 14 '25 04:03 softdevca

since ureq is re-exported as part of the public interface when the ureq feature is enabled, this is a breaking change that would need to wait for the next major release (not planned any time soon). however, I'd be willing to accept the change behind a separate feature flag (e.g., ureq-3) that preserves the current version when the ureq feature is used.

ramosbugs avatar Apr 27 '25 05:04 ramosbugs

Hello,

Would it be possible to get the re-exporting done through a flag? This would be useful for the project I'm part of to reduce dependencies.

Many thanks, SO9010

Edit: I've just realized that it's probably deeper than just re-exporting. I would be happy to, if I have the time, to go though and up date the code to 3.0.

SO9010 avatar May 18 '25 23:05 SO9010

@SO9010 did you end up finding out what needed to be done for this PR to work?

hanyuone avatar Sep 10 '25 01:09 hanyuone

It is quite a bit of work, ureq-3 is completely different... you just need to go through and reimplement all of usages. It's not hard just pretty damn verbose.

Tldr: no I didn't, we just left it as it was.

SO9010 avatar Sep 10 '25 11:09 SO9010

I had a go at this in #324

algesten avatar Sep 10 '25 19:09 algesten