Ramon Petgrave comments

Results 156 comments of


                                            Ramon Petgrave

ERROR:cartography.sync:Unhandled exception during sync stage 'create-indexes'

Are you sure you're running Neo4j 4.4 and not 3.x or 5.x?

AWS: Extend aws_handle_regions to cover IAM get functions

@alowde-ps While you're getting the tests to work, I've been thinking a bit more on this. What you're proposing sounds like a best-effort mode, which I think is a significant...

AWS Inspector sync issue

related #988

Create pull_request_template.md

@resilience-jychp , what do you think?

Create pull_request_template.md

@achantavy @resilience-jychp Thanks. I've shortened it and mentioned the readme

fixed typo in Azure load_vms cypher

@amirjalali65 It looks like the commit you authored doesn't have your actual github name associated with the commit. You'll need to setup your git config https://docs.github.com/en/pull-requests/committing-changes-to-your-project/troubleshooting-commits/why-are-my-commits-linked-to-the-wrong-user

fixed typo in Azure load_vms cypher

@amirjalali65 Some of the commits still have the wrong author, so you'll need to rebase/squash and maybe do a force-push. https://github.com/lyft/cartography/pull/1047/commits

fixed typo in Azure load_vms cypher

Looks good. Docs here: https://learn.microsoft.com/en-us/python/api/azure-mgmt-compute/azure.mgmt.compute.v2021_03_01.models.osprofile?view=azure-python

fix: SessionExpired issue

Hey! Thanks for this. This could be a good solution, until the neo4j client libraries become more flexible with timeouts. Can you into potential performance impacts?

Adding support for determining the last used date of an access keys

Also, about the CLA check. It looks like you need to go back and edit the first two commits' authors to be explicitly set to @csanders-git. And then force-push.