Ramon de Klein

Results 147 comments of Ramon de Klein

Didn't see that one... Will check next time, before implementation. I will take the best parts of both PRs and merge it into a single PR. This PR has some...

I started off with https://github.com/jiuker/kes/tree/upgrade_azserect_client and made some changes: * If no explicit Azure credentials are specified (client/secret or managed identity), then it falls back to the default Azure credentials...

@harshavardhana I have rebased @jiuker changes to our current `master` and applied my changes in commit [e59983b768645b7bcd7e53f82ecbb6c04e934562](https://github.com/minio/kes/pull/459/commits/e59983b768645b7bcd7e53f82ecbb6c04e934562). This could supersede #430.

@aead Why does it explicitly try to load the first version? If no version is supplied, then the default Azure KeyVault behavior is to fetch the most recent version. Because...

> Do you have access to Azure Vault to test this? I tested this in my private Azure account, but I could create instructions on how to test it in...

@harshavardhana I have added a script in `internal/keystore/azure/create-keyvault.sh` that will create an Azure key-vault in your current subscription and add the required permission to use it in the unit-test. If...

Processed review comment (only for reporting error for JSON deserialization issue) and rebased on the current `master` branch.

@domaindrivendev I ran `dotnet tool install swashbuckle.aspnetcore.cli --version 7.0.0-preview-2114 --add-source https://www.myget.org/F/domaindrivendev/api/v3/index.json` in a `mcr.microsoft.com/dotnet/sdk:7.0-jammy` container and it seems to run fine. Running the 6.4.0 version shows the missing runtime message,...

@domaindrivendev Is there an ETA for a release that works for .NET 7?

The actual problem is that base64 encoding is used to encode the username, but standard base64 encoding is not URL-safe (standard base64 encoding uses the `+` and `/` characters). To...