mellifluous.nvim icon indicating copy to clipboard operation
mellifluous.nvim copied to clipboard

SignColumn in Neogit

Open windowsrefund opened this issue 1 year ago • 4 comments

Greets,

Neogit makes use of the sign column to show the status of internal folds.

image

image

When Mellifluous is active, SignColumn is linked to LineNr. Normally, this is great but we can see how it breaks down against the NeogitStatus file type.

By comparison, a look at the same thing via the default Astronvim theme has that area of the tool looking much cleaner.

image

and I see when that theme is active, SignColumn is cleared.

So back to our favorite scheme, Mellifluous, I can't understand why that sign column is behaving like this? Even though it's linked to LineNr, it is behaving in a way where the bg color is highlighting when it should just sit there and remain dark. Of course, the real move here would be to simply ignore it and move on but I'm finding that to be a challenge :)

windowsrefund avatar Oct 28 '24 16:10 windowsrefund

Yeah, it doesn't look good, the backgrounds in signcolumn should match. I don't use Neogit, so I'm not really motivated to investigate this. There might be some Neogit highlight group that you could set, or you can clear the SignColumn highlight group.

I think Neogit just sets their own highlight group that by default doesn't respect the background of SignColumn. It might be worth creating an issue there.

ramojus avatar Oct 29 '24 20:10 ramojus

Turns out things are good when foldcolumn is used rather than signcolumn. I've asked the hard-coded options be removed here

windowsrefund avatar Nov 01 '24 03:11 windowsrefund

That is strange image image

So it respects the background of foldcolumn, but doesn't respect the background of signcolumn? Or do you use different FoldColumn highlight than default?

ramojus avatar Nov 01 '24 09:11 ramojus

I was saying that everything works as expected when foldcolumn is enabled and signcolumn is not. My understanding is that Neogit essentially displays the same information in both and that the developer has decided to hard-code setting foldcolumn=0. Seeing if I can convince them to not hard-code anything so the end user can decide where they want the folds displayed. As to why the SignColumn highlighting isn't working, I don't know but it won't matter if I can just lean into using foldcolumn.

windowsrefund avatar Nov 01 '24 17:11 windowsrefund